Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test against node 22 #1890

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 26, 2024

Node 22 will become LTS in October 2024

Refs: https://github.com/nodejs/release

On a related note, Node 16 has been EOL for over a year. I'd be happy to remove it if the project wishes to do so.

Node 22 will become LTS in October 2024

Refs: https://github.com/nodejs/release
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @cjihrig!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2024
@mstruebing
Copy link
Member

mstruebing commented Sep 26, 2024

Thank you for the PR. I actually think it would be a good idea to remove node 16, will wait for @brendanburns to confirm it's okay to remove.

In the meanwhile - could you make the same change in the release-1.x branch which will become the new master soon™️

@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 26, 2024

could you make the same change in the release-1.x branch

Sure - #1892

@brendandburns
Copy link
Contributor

Yeah, let's remove node 16

@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 26, 2024

Yeah, let's remove node 16

Should I target both master and release-1.x, or just one of them?

@mstruebing
Copy link
Member

Both please! :)

Node 16 has been EOL. This commit removes it from the CI matrix.
@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 26, 2024

I pushed the Node 16 changes to this PR and #1892 as separate commits so that they can be merged at the same time without introducing conflicts.

@mstruebing
Copy link
Member

/lgtm
/approve

Thanks 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit adf9d24 into kubernetes-client:master Sep 26, 2024
7 checks passed
@cjihrig cjihrig deleted the node22 branch September 26, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants