Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write permissions to deploy docs #2024

Merged

Conversation

clayrosenthal
Copy link

Fixing #2023, based on the repo for the action.

GitHub changed new repository default settings and made workflow permissions read-only by default. The fix was to add write permissions to the workflow:

permissions:
  contents: write

Copy link

linux-foundation-easycla bot commented Nov 12, 2024

CLA Signed

  • ✅login: clayrosenthal / (e3188dd)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @clayrosenthal!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 12, 2024
@mstruebing
Copy link
Member

/lgtm
/approve

Thanks 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clayrosenthal, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit d1649bc into kubernetes-client:master Nov 13, 2024
7 checks passed
@mstruebing
Copy link
Member

mstruebing commented Nov 13, 2024

It is still not working because of the easy CLA requirement.
I'm not sure if there is any way around this without a private access token.

@clayrosenthal
Copy link
Author

I'm not too familiar with easy CLA, but can you change a setting to allow actions to bypass the requirement? Or make the CI bot considered having signed the CLA?

@clayrosenthal clayrosenthal deleted the fix-deploy-docs branch November 13, 2024 18:14
@clayrosenthal
Copy link
Author

@mstruebing Another repo had a similar issue, it looks like you can add k8s-ci-robot to the EasyCLA allow list. Or perhaps sign in as the bot and open a dummy PR then sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants