Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to push a non pre-release to NPM #2114

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

brendandburns
Copy link
Contributor

Final piece needed to cut the 1.0.0 release, I think.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2024
@brendandburns
Copy link
Contributor Author

cc @cjihrig @mstruebing

@brendandburns
Copy link
Contributor Author

Hrm, looks like some prettier thing reformatted the YAML file, so it looks all changed. Let me know if you want me to revert the whitespace changes.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 18, 2024

Viewing the diff with ?w=1 added to the end of the URL takes care of that problem.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 18, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, cjihrig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1da8d10 into release-1.x Dec 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants