Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative path loading. #226

Merged
merged 1 commit into from
Mar 24, 2019

Conversation

brendandburns
Copy link
Contributor

Fixes #224

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2019
@k8s-ci-robot k8s-ci-robot requested review from drubin and mbohlool March 21, 2019 23:56
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2019
@drubin
Copy link
Contributor

drubin commented Mar 22, 2019

@brendanburns I was going to ask about if this makes sense or if we should load the path relative to the proccess working directory.

BUT I see yet again the k8s docs/spec is so well documented https://github.com/kubernetes/kubernetes/pull/20328/files

You need to fix the linting but then I think it should be good to go.

@brendandburns
Copy link
Contributor Author

@drubin lint fixed, I think this is ready to go.

Thanks!

@drubin
Copy link
Contributor

drubin commented Mar 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3811829 into kubernetes-client:master Mar 24, 2019
@starpit
Copy link

starpit commented Jun 5, 2019

for future reference: this fix does not work for configs loaded directly from string, a fallback which is required for users that have a colon-separated KUBECONFIG (which is not supported by loadConfigFromDefault())

@drubin
Copy link
Contributor

drubin commented Jun 5, 2019

@starpit I added an issue to add this functionality into the client, See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path to ca.pem must be absolute
4 participants