-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relative path loading. #226
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@brendanburns I was going to ask about if this makes sense or if we should load the path relative to the proccess working directory. BUT I see yet again the k8s docs/spec is so well documented https://github.com/kubernetes/kubernetes/pull/20328/files You need to fix the linting but then I think it should be good to go. |
@drubin lint fixed, I think this is ready to go. Thanks! |
/lgtm |
for future reference: this fix does not work for configs loaded directly from string, a fallback which is required for users that have a colon-separated KUBECONFIG (which is not supported by loadConfigFromDefault()) |
@starpit I added an issue to add this functionality into the client, See above. |
Fixes #224