-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed condition to check expired token for exec auth #237
Fixed condition to check expired token for exec auth #237
Conversation
Fixes kubernetes-client#228 It also fixes the issue where if the token is valid it was regenerating every time.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed CLA |
/assign @brendanburns |
/lgtm Thanks for the PR (we should really add a unit test for this) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitabhopatkar13, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #228
It also fixes the issue where if the token is valid it was regenerating every time.