Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from jsonpath to jsonpath-plus #248

Merged
merged 1 commit into from
May 24, 2019

Conversation

drubin
Copy link
Contributor

@drubin drubin commented May 24, 2019

jsonpath is almost unmaintained and has security and deprecation warnings.

I haven't manually verified this but I did verify there were cases and they still pass.

Fixes #247

/assign @brendanburns

cc/ @1N50MN14

Side note: This is why having tests are amazing! Thanks, @brendanburns for always being so awesome at adding new tests.

@k8s-ci-robot
Copy link
Contributor

@drubin: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes-client members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

jsonpath is almost unmaintained and has security and deprecation warnings.

I haven't manually verified this but I did verify there were cases and they still pass.

Fixes #247

/assign @brendanburns

cc/ @1N50MN14

Side note: This is why having tests are amazing! Thanks, @brendanburns for always being so awesome at adding new tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot requested review from itowlson and mbohlool May 24, 2019 15:26
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2019
jsonpath is almost unmaintained and has security and deprecation warnings.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 24, 2019
@drubin
Copy link
Contributor Author

drubin commented May 24, 2019

/assign @brendandburns

@1N50MN14
Copy link

@drubin @brendandburns Thank you for the quick turnaround on this issue, and generally for your work on this library, it's been a time saver for me. Looking forward to upgrading version once this PR gets merged upstream and npm published.

Thanks again

@brendandburns
Copy link
Contributor

/lgtm
/approve

I'll cut a new release once this merges...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, drubin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit c0a5ca0 into kubernetes-client:master May 24, 2019
@drubin
Copy link
Contributor Author

drubin commented May 24, 2019

@brendandburns let's wait to include your other Mr that fixes env handling too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency deprecation warning
4 participants