-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from jsonpath to jsonpath-plus #248
Conversation
@drubin: GitHub didn't allow me to assign the following users: brendanburns. Note that only kubernetes-client members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jsonpath is almost unmaintained and has security and deprecation warnings.
/assign @brendandburns |
@drubin @brendandburns Thank you for the quick turnaround on this issue, and generally for your work on this library, it's been a time saver for me. Looking forward to upgrading version once this PR gets merged upstream and npm published. Thanks again |
/lgtm I'll cut a new release once this merges... |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, drubin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@brendandburns let's wait to include your other Mr that fixes env handling too? |
jsonpath is almost unmaintained and has security and deprecation warnings.
I haven't manually verified this but I did verify there were cases and they still pass.
Fixes #247
/assign @brendanburns
cc/ @1N50MN14
Side note: This is why having tests are amazing! Thanks, @brendanburns for always being so awesome at adding new tests.