Handle JSON parse errors in watch implementation #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/L
drubin
reviewed
May 27, 2019
src/watch.ts
Outdated
| @@ -1,4 +1,5 @@ | |||
| import { LineStream } from 'byline'; | |||
There was a problem hiding this comment.
Is this still used?
Also not sure the linter didn't pick this up.
drubin
reviewed
May 27, 2019
package.json
Outdated
| @@ -56,6 +56,7 @@ | |||
| "byline": "^5.0.0", | |||
There was a problem hiding this comment.
This doesn't seem to be needed anymore either?
This change "handles" JSON parse parse errors in the watch implementation by ignoring them: the JSONStream implementation ignores parsing errors. The request might result in invalid JSON if, for example, the HTTP connection is abruptly terminated (and a partial line is piped to the transform stream). The code this commit replaces would raise an uncaught exception exception on parse errors. An alternative approach to this commit would invoke the `done` callback with parse errors, but that could result in multiple invocations of the `done` callback.
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
@silasbw Thanks for fixing this and for adding a test /lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @brendandburns |
|
/approve thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, silasbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change "handles" JSON parse errors in the watch implementation by
ignoring them: the JSONStream implementation ignores parsing errors.
The request might result in invalid JSON if, for example, the HTTP connection
is abruptly terminated (and a partial line is piped to the transform stream).
The code this commit replaces would raise an uncaught exception exception on
parse errors. An alternative approach to this commit would invoke the
donecallback with parse errors, but that could result in multiple invocations of
the
donecallback.