Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split watch error and watch done handlers. #555

Merged
merged 1 commit into from
Nov 16, 2020
Merged

split watch error and watch done handlers. #555

merged 1 commit into from
Nov 16, 2020

Conversation

brendandburns
Copy link
Contributor

fixes #552

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from drubin November 13, 2020 22:24
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2020
@brendandburns brendandburns mentioned this pull request Nov 13, 2020
Closed
@brendandburns
Copy link
Contributor Author

self LGTM given LGTM in the issue thread (#552 (comment))

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 437218d into kubernetes-client:master Nov 16, 2020
@brendandburns brendandburns mentioned this pull request Nov 22, 2020
Closed
@brendandburns brendandburns mentioned this pull request Dec 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drubin drubin Awaiting requested review from drubin

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Done handler gets called twice when watch aborts
2 participants
@brendandburns @k8s-ci-robot