Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly abort and destroy active requests before re-initiating a watch. #575

Closed
wants to merge 1 commit into from
Closed

Explicitly abort and destroy active requests before re-initiating a watch. #575

wants to merge 1 commit into from

Conversation

brendandburns
Copy link
Contributor

Maybe fixes #494?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from drubin January 5, 2021 05:31
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2021
@brendandburns brendandburns mentioned this pull request Jan 5, 2021
Closed
@drubin
Copy link
Contributor

drubin commented Jan 5, 2021

@brendanburns since this is all wrapped in try and catch I don't see it breaking anything.

But I am also unable to see how this could fix the issue. My guess is we are just going to hide the underlying issue so it might be easier to try to create a test to reproduce the issue and then assert its fixes it.

Just to be clear, not opposed to approving this but it seems like going around in circles might not be the best.

@jkryl jkryl mentioned this pull request Jan 11, 2021
Merged
@k8s-ci-robot
Copy link
Contributor

@brendandburns: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2021
@brendandburns
Copy link
Contributor Author

Closing this since it was obsoleted by #576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drubin drubin Awaiting requested review from drubin

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection leak in informer?
4 participants
@brendandburns @k8s-ci-robot @drubin @brendanburns