-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrades tar version from 6.0.2 to 6.1.11 #770
upgrades tar version from 6.0.2 to 6.1.11 #770
Conversation
Welcome @Tenaria! |
package-lock.json
Outdated
@@ -5688,8 +5688,7 @@ | |||
"dev": true | |||
}, | |||
"colors": { | |||
"version": "1.4.0", | |||
"resolved": "https://registry.npmjs.org/colors/-/colors-1.4.0.tgz", | |||
"version": "https://registry.npmjs.org/colors/-/colors-1.4.0.tgz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why the colors version is changing too?
This looks fine, but there appears to be an unrelated change to the colors dependency. |
@brendandburns I believe there was a typo introduced by this PR https://github.com/kubernetes-client/javascript/pull/767/files (see the first link on the PR description which recommends to downgrade colors to 1.4.0 but we pinned it to 1.40.0 which doesn't exist https://www.npmjs.com/package/colors). This is probably the root cause, I've pushed a fix. 🙇 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, Tenaria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! @brendandburns 🙇 |
How often / how do you determine when to create a release btw? @brendandburns Just wondering when I can expect this change to officially get released. Thanks! |
Upgrade tar version to 6.1.11 and run
npm install
to resolve security vulnerability. This is a minor bump and should not have breaking changes.npm test
passes.ticket: #769.