Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades tar version from 6.0.2 to 6.1.11 #770

Merged

Conversation

Tenaria
Copy link
Contributor

@Tenaria Tenaria commented Jan 28, 2022

Upgrade tar version to 6.1.11 and run npm install to resolve security vulnerability. This is a minor bump and should not have breaking changes. npm test passes.

ticket: #769.

@k8s-ci-robot
Copy link
Contributor

Welcome @Tenaria!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2022
@@ -5688,8 +5688,7 @@
"dev": true
},
"colors": {
"version": "1.4.0",
"resolved": "https://registry.npmjs.org/colors/-/colors-1.4.0.tgz",
"version": "https://registry.npmjs.org/colors/-/colors-1.4.0.tgz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why the colors version is changing too?

@brendandburns
Copy link
Contributor

This looks fine, but there appears to be an unrelated change to the colors dependency.

@Tenaria
Copy link
Contributor Author

Tenaria commented Jan 31, 2022

@brendandburns I believe there was a typo introduced by this PR https://github.com/kubernetes-client/javascript/pull/767/files (see the first link on the PR description which recommends to downgrade colors to 1.4.0 but we pinned it to 1.40.0 which doesn't exist https://www.npmjs.com/package/colors). This is probably the root cause, I've pushed a fix. 🙇

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Tenaria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit fae1e5b into kubernetes-client:master Feb 3, 2022
@Tenaria Tenaria deleted the fix-tar-vulnerability branch February 3, 2022 23:26
@Tenaria
Copy link
Contributor Author

Tenaria commented Feb 4, 2022

Thanks! @brendandburns 🙇

@Tenaria
Copy link
Contributor Author

Tenaria commented Feb 7, 2022

How often / how do you determine when to create a release btw? @brendandburns

Just wondering when I can expect this change to officially get released. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants