Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Add support for bookmark events #286

Closed
cansjt opened this issue Feb 28, 2022 · 4 comments
Closed

Add support for bookmark events #286

cansjt opened this issue Feb 28, 2022 · 4 comments

Comments

@cansjt
Copy link

cansjt commented Feb 28, 2022

In #234 the parsing of BOOKMARK events has been bypassed. But those events exist for a reason and can be useful in some circumstances. And motivational example is this Airflow issue: apache/airflow#21087.

As Airflows scheduler can be stopped and restarted, while many events occur on k8s, it would need to process BOOKMARK to recover its state. Sadly because those are ignored by the Python client, it cannot. Which manifests itself in varied ways (see the different issues referenced in the ticket above)

@roycaihw
Copy link
Member

HI @cansjt, thanks for sending the issue! This python-base repo has been merged into the main python repo, and is being archived. Would you mind sending the issue to the python repo?

@cansjt
Copy link
Author

cansjt commented Feb 28, 2022

Done. I am guessing I can close this issue, right?

@roycaihw
Copy link
Member

roycaihw commented Mar 4, 2022

Yes. Thank you!

/close

@k8s-ci-robot
Copy link
Contributor

@roycaihw: Closing this issue.

In response to this:

Yes. Thank you!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants