Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Conversation

roycaihw
Copy link
Member

Cherry pick of #79 on release-9.0-base64-patch.

#79: Fix base64 padding for kube config

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #146 into release-9.0-base64-patch will increase coverage by 0.02%.
The diff coverage is 86.95%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           release-9.0-base64-patch     #146      +/-   ##
============================================================
+ Coverage                     92.11%   92.13%   +0.02%     
============================================================
  Files                            13       13              
  Lines                          1217     1234      +17     
============================================================
+ Hits                           1121     1137      +16     
- Misses                           96       97       +1
Impacted Files Coverage Δ
config/kube_config_test.py 94.55% <100%> (+0.13%) ⬆️
config/kube_config.py 83.9% <66.66%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d69e89...b013697. Read the comment docs.

@yliaog
Copy link
Contributor

yliaog commented Jul 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 54a0210 into kubernetes-client:release-9.0-base64-patch Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants