Add option to refresh gcp token when config is cmd-path #175

jfrabaute · 2019-10-23T22:18:27Z

The python client does not deal with "gcloud" gke auth in the kube config file as it's based on the "cmd-path" auth.

This is adding the code to take care of this auth.
This should solve kubernetes-client/python#754

jfrabaute · 2019-10-24T00:40:58Z

Looks like the test is failing on python style code problems on unrelated files (not thouched in that review).
I fixed a few, but I have one that I don't know about:

/tmp/tmp.0CpklmniPV/python/kubernetes/utils/quantity.py:24:80: E501 line too long (91 > 79 characters)

roycaihw · 2019-10-29T17:36:33Z

/assign @yliaog

micw523 · 2019-10-29T17:40:50Z

The CI is failing on the files you modified. Take a look at the diff output - or to save time, just use autopep8 --aggressive --aggressive --in-place kube_config.py.

E501 is ignored in judging the success of the CI task.

jfrabaute · 2019-10-29T20:43:07Z

The CI is failing on the files you modified. Take a look at the diff output - or to save time, just use autopep8 --aggressive --aggressive --in-place kube_config.py.

Oops, yes. Fixed, build seems to pass now.

jfrabaute · 2019-12-19T16:26:21Z

Hi,

Any chance to have this reviewed?

config/kube_config.py

yliaog · 2020-01-06T19:02:03Z

config/kube_config.py

@@ -133,6 +135,47 @@ def as_data(self):
        return self._data


+class CommandTokenSource(object):
+    def __init__(self, cmd, args, tokenKey, expiryKey):
+


why the extra blank line here?

Fixed (when PR will be updated)

config/kube_config_test.py

yliaog · 2020-01-06T19:06:58Z

config/kube_config_test.py

@@ -1439,7 +1444,8 @@ def test_list_kube_config_contexts(self):
            {'context': {'cluster': 'ssl', 'user': 'ssl'}, 'name': 'ssl'},
            {'context': {'cluster': 'default', 'user': 'simple_token'},
             'name': 'simple_token'},
-            {'context': {'cluster': 'default', 'user': 'expired_oidc'}, 'name': 'expired_oidc'}]
+            {'context': {'cluster': 'default', 'user': 'expired_oidc'},
+             'name': 'expired_oidc'}]


please add a test case

Working on it.

Added tests and updated the PR.

codecov-io · 2020-01-07T00:26:19Z

Codecov Report

Merging #175 into master will decrease coverage by 0.94%.
The diff coverage is 74.02%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   93.41%   92.46%   -0.95%     
==========================================
  Files          13       13              
  Lines        1398     1474      +76     
==========================================
+ Hits         1306     1363      +57     
- Misses         92      111      +19

Impacted Files	Coverage Δ
config/kube_config_test.py	`95.56% <100%> (+0.27%)`	⬆️
config/kube_config.py	`84.25% <57.44%> (-3.28%)`	⬇️
config/dateutil.py	`97.91% <0%> (+2.08%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d1024...39113de. Read the comment docs.

config/kube_config_test.py

yliaog · 2020-01-08T19:33:00Z

/lgtm
/approve

k8s-ci-robot · 2020-01-08T19:33:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jfrabaute, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jfrabaute · 2020-01-08T19:39:02Z

Thanks @yliaog for the reviews.
I'll work on the other PR and add tests now: #169

palnabarun · 2020-03-03T07:37:25Z

Note to self: We should add documentation for the functionality implemented here.

/cc

cc: @roycaihw

jfrabaute mentioned this pull request Oct 23, 2019

Add option to refresh gcp token when config is cmd-path #168

Closed

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2019

k8s-ci-robot requested review from roycaihw and yliaog October 23, 2019 22:19

jfrabaute force-pushed the cmdpath branch from 423710c to bb11904 Compare October 23, 2019 22:45

k8s-ci-robot assigned yliaog Oct 29, 2019

jfrabaute force-pushed the cmdpath branch from bb11904 to 4f5c5cf Compare October 29, 2019 20:12

yliaog reviewed Jan 6, 2020

View reviewed changes

jfrabaute force-pushed the cmdpath branch from 4f5c5cf to 1b6fdcf Compare January 7, 2020 00:14

jfrabaute force-pushed the cmdpath branch from 1b6fdcf to 8764043 Compare January 8, 2020 04:47

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2020

jfrabaute force-pushed the cmdpath branch 3 times, most recently from ebb2bc7 to eeb8b54 Compare January 8, 2020 05:10

yliaog reviewed Jan 8, 2020

View reviewed changes

config/kube_config_test.py Outdated Show resolved Hide resolved

config/kube_config_test.py Outdated Show resolved Hide resolved

config/kube_config_test.py Outdated Show resolved Hide resolved

config/kube_config_test.py Outdated Show resolved Hide resolved

jfrabaute force-pushed the cmdpath branch 2 times, most recently from 0ee3cb5 to d3bc0a9 Compare January 8, 2020 19:17

Add option to refresh gcp token when config is cmd-path

39113de

jfrabaute force-pushed the cmdpath branch from d3bc0a9 to 39113de Compare January 8, 2020 19:28

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020

k8s-ci-robot merged commit 7ea5cb4 into kubernetes-client:master Jan 8, 2020

k8s-ci-robot requested a review from palnabarun March 3, 2020 07:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add option to refresh gcp token when config is cmd-path #175

Add option to refresh gcp token when config is cmd-path #175

jfrabaute commented Oct 23, 2019

jfrabaute commented Oct 24, 2019

roycaihw commented Oct 29, 2019

micw523 commented Oct 29, 2019

jfrabaute commented Oct 29, 2019

jfrabaute commented Dec 19, 2019

yliaog Jan 6, 2020

jfrabaute Jan 6, 2020

yliaog Jan 6, 2020

jfrabaute Jan 7, 2020

jfrabaute Jan 8, 2020

codecov-io commented Jan 7, 2020 •

edited

Loading

yliaog commented Jan 8, 2020

k8s-ci-robot commented Jan 8, 2020

jfrabaute commented Jan 8, 2020

palnabarun commented Mar 3, 2020

Add option to refresh gcp token when config is cmd-path #175

Add option to refresh gcp token when config is cmd-path #175

Conversation

jfrabaute commented Oct 23, 2019

jfrabaute commented Oct 24, 2019

roycaihw commented Oct 29, 2019

micw523 commented Oct 29, 2019

jfrabaute commented Oct 29, 2019

jfrabaute commented Dec 19, 2019

yliaog Jan 6, 2020

Choose a reason for hiding this comment

jfrabaute Jan 6, 2020

Choose a reason for hiding this comment

yliaog Jan 6, 2020

Choose a reason for hiding this comment

jfrabaute Jan 7, 2020

Choose a reason for hiding this comment

jfrabaute Jan 8, 2020

Choose a reason for hiding this comment

codecov-io commented Jan 7, 2020 • edited Loading

Codecov Report

yliaog commented Jan 8, 2020

k8s-ci-robot commented Jan 8, 2020

jfrabaute commented Jan 8, 2020

palnabarun commented Mar 3, 2020

codecov-io commented Jan 7, 2020 •

edited

Loading