Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Allow setting maxsize for PoolManager #18

Merged
merged 2 commits into from
Jul 9, 2017
Merged

Allow setting maxsize for PoolManager #18

merged 2 commits into from
Jul 9, 2017

Conversation

yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Jul 9, 2017

@yuvipanda
Copy link
Contributor Author

I'm guessing I've to manually bump the submodule ref in client-python after this gets merged?

@codecov-io
Copy link

codecov-io commented Jul 9, 2017

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files           9        9           
  Lines         698      698           
=======================================
  Hits          661      661           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26cb526...d339d7c. Read the comment docs.

configuration.py Outdated
# per pool. Increasing this is useful for cases when you are
# making a lot of possibly parallel requests to the same host,
# which is often the case here.
self.connection_pool_maxsize = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change default value to 1. I don't know what default value is, but it is safer to set this to None and add an if statement in the other file to set it if not none.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per http://urllib3.readthedocs.io/en/latest/advanced-usage.html the default value is 1 but I agree we should use None and pass through. Shall amend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants