Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

FileOrData: Handle None object #201

Merged
merged 1 commit into from
Jul 29, 2020
Merged

FileOrData: Handle None object #201

merged 1 commit into from
Jul 29, 2020

Conversation

Akasurde
Copy link
Contributor

@Akasurde Akasurde commented Jul 2, 2020

Return when object is None in FileOrData class

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

@Akasurde
FileOrData: Handle None object
a270ea2 
Return when object is None in FileOrData class

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @Akasurde!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 2, 2020
@Akasurde
Copy link
Contributor Author

Akasurde commented Jul 2, 2020

/assign @roycaihw

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 2, 2020
@Akasurde Akasurde mentioned this pull request Jul 2, 2020
Closed
@roycaihw
Copy link
Member

roycaihw commented Jul 6, 2020

/cc @palnabarun

@Akasurde
Copy link
Contributor Author

@roycaihw Does this require anything from my side?

@Akasurde
Copy link
Contributor Author

@roycaihw @palnabarun Any news? Do you need anything my side? Thanks.

@Akasurde
Copy link
Contributor Author

@roycaihw @palnabarun Any news ?

@yliaog
Copy link
Contributor

yliaog commented Jul 29, 2020

Thanks.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akasurde, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit ab61ca3 into kubernetes-client:master Jul 29, 2020
@Akasurde
Copy link
Contributor Author

@yliaog Thanks for the review and merge.

@Akasurde Akasurde deleted the kube_config_no_obj_fix branch July 29, 2020 16:48
palnabarun added a commit to palnabarun/python that referenced this pull request Aug 19, 2020
@palnabarun
Update the CHANGELOG and README
48230f3 
- Adds a bug fix on python-base Ref: kubernetes-client/python-base#201
- kubernetes-client#1220 wrongly added
changes to the 12.0.0a1 CHANGELOG. We should not modify CHANGELOGs after
a release is made.

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
palnabarun added a commit to palnabarun/python that referenced this pull request Sep 9, 2020
@palnabarun
Update the CHANGELOG and README
ce6a89d 
- Adds a bug fix on python-base Ref: kubernetes-client/python-base#201
- kubernetes-client#1220 wrongly added
changes to the 12.0.0a1 CHANGELOG. We should not modify CHANGELOGs after
a release is made.
- Update 12.0.0a1-snapshot to 12.0.0a1

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun palnabarun mentioned this pull request Sep 9, 2020
Merged
palnabarun added a commit to palnabarun/python that referenced this pull request Sep 15, 2020
@palnabarun
Update the CHANGELOG and README
de822a2 
- Adds a bug fix on python-base Ref: kubernetes-client/python-base#201
- kubernetes-client#1220 wrongly added
changes to the 12.0.0a1 CHANGELOG. We should not modify CHANGELOGs after
a release is made.
- Update 12.0.0a1-snapshot to 12.0.0a1

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
This was referenced Mar 15, 2021
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yliaog yliaog yliaog left review comments

@roycaihw roycaihw Awaiting requested review from roycaihw

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@roycaihw roycaihw

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Akasurde @k8s-ci-robot @roycaihw @yliaog