Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Add Python 3.9 to build #217

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Add Python 3.9 to build #217

merged 1 commit into from
Dec 14, 2020

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Nov 23, 2020

Signed-off-by: Gábor Lipták gliptak@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @gliptak!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2020
@gliptak
Copy link
Contributor Author

gliptak commented Nov 23, 2020

/assign @roycaihw

@roycaihw
Copy link
Member

waiting for the 3.8 & 3.9 jobs to finish: https://travis-ci.org/github/kubernetes-client/python-base/builds/745486231

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2020
@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #217 (3412151) into master (2da2b98) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files          13       13           
  Lines        1635     1635           
=======================================
  Hits         1509     1509           
  Misses        126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da2b98...3412151. Read the comment docs.

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@gliptak
Copy link
Contributor Author

gliptak commented Nov 24, 2020

waiting for https://travis-ci.org/github/kubernetes-client/python-base/builds/745761288

maybe time to move build to GHA

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@gliptak
Copy link
Contributor Author

gliptak commented Dec 5, 2020

@yliaog
Copy link
Contributor

yliaog commented Dec 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2020
@gliptak
Copy link
Contributor Author

gliptak commented Dec 5, 2020

@yliaog
Copy link
Contributor

yliaog commented Dec 5, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gliptak, roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gliptak
Copy link
Contributor Author

gliptak commented Dec 13, 2020

any other updates for this PR?

@yliaog
Copy link
Contributor

yliaog commented Dec 14, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit fdc9907 into kubernetes-client:master Dec 14, 2020
@gliptak gliptak deleted the python1 branch December 14, 2020 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants