Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

configmap e2e: use labels and label selector #222

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

roycaihw
Copy link
Member

@roycaihw roycaihw commented Jan 5, 2021

The Bound Service Account Tokens feature creates a configmap kube-root-ca.crt in every namespace. Use a label to select the test objects we create.

/hold
wait for the tests to pass

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2021
@yliaog
Copy link
Contributor

yliaog commented Jan 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
@roycaihw
Copy link
Member Author

roycaihw commented Jan 5, 2021

https://travis-ci.org/github/kubernetes-client/python-base/jobs/752929229

=========================== short test summary info ============================
FAILED kubernetes/e2e_test/test_client.py::TestClient::test_configmap_apis - ...
FAILED kubernetes/e2e_test/test_watch.py::TestClient::test_watch_configmaps
============ 2 failed, 246 passed, 2 warnings in 165.50s (0:02:45) =============

The failing tests are in the python repo. The one in this repo (python-base) has passed.

kubernetes/base/dynamic/test_client.py::TestDynamicClient::test_configmap_apis PASSED

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2021
@roycaihw roycaihw merged commit b002110 into kubernetes-client:master Jan 5, 2021
@roycaihw roycaihw deleted the configmap-e2e/labels branch January 5, 2021 17:51
@yliaog yliaog mentioned this pull request Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants