This repository has been archived by the owner on Mar 13, 2022. It is now read-only.
Fix issue when refreshing service account token #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 93.36% 93.36%
=======================================
Files 11 11
Lines 829 829
=======================================
Hits 774 774
Misses 55 55
Continue to review full report at Codecov.
|
|
Bump to verify CLA |
|
Thanks for your contribution. You also need to send a PR to the main repo updating this sub-module. |
|
How can I get this fix? I tried cloning and I don't see it. |
|
@michrabi you should create a PR to the main repo (https://github.com/kubernetes-client/python) updating the submodule to include this commit. See: https://github.com/kubernetes-client/python/blob/master/devel/submodules.md Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbohlool I believe this will fix the below issues:
kubernetes-client/python#339
kubernetes-client/python#386
I was able to reproduce this issue by either setting GOOGLE_APPLICATION_CREDENTIALS to a service account json key file or by setting the gcloud default application login to a service account.
Unlike user accounts, it seems that service accounts require that we set the scope.