Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2 #1054

Closed
palnabarun opened this issue Jan 10, 2020 · 16 comments
Closed

Drop support for Python 2 #1054

palnabarun opened this issue Jan 10, 2020 · 16 comments
Assignees

Comments

@palnabarun
Copy link
Member

Python 2 has reached End of Life as of January 1, 2020 and we are still supporting it. Releasing future versions of the client and maintaining released versions with Python 2 support might lead to problems for downstream users.

My suggestion is to stop releasing the client with Python 2 support and removing Python 2.7 from CI/CD.

Also, it would be helpful if we provide a warning message in the README against using Python 2 versions of already released client versions.

@palnabarun
Copy link
Member Author

/assign

@palnabarun
Copy link
Member Author

@micw523
Copy link
Contributor

micw523 commented Jan 10, 2020

I think we should probably wait till v12 stable is released to accommodate a client version for server version v1.16, which brought many breaking changes. What do you think?
/assign

@yliaog
Copy link
Contributor

yliaog commented Jan 10, 2020

it's good to stop supporting python 2 in next release. before that, please make an announcement about it in dev mailing list and slack channel.

@palnabarun
Copy link
Member Author

I think we should probably wait till v12 stable is released to accommodate a client version for server version v1.16, which brought many breaking changes. What do you think?

I agree. We can do that.

@palnabarun
Copy link
Member Author

it's good to stop supporting python 2 in next release. before that, please make an announcement about it in dev mailing list and slack channel.

Sure. I will draft an email and get it reviewed in the next meeting.

@fabianvf
Copy link
Contributor

My only concern with this is that we are seeing this bug consistently in Python 3, but not in Python 2, #1037

With that issue resolved I would support dropping Python 2 support

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2020
@palnabarun
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2020
@palnabarun
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 20, 2020
@palnabarun
Copy link
Member Author

palnabarun commented Jun 22, 2020

The roadmap that we discussed in the previous meetings based on the comments here:

  1. Keep the support for Python 2 in Kubernetes Client v12.0.0
  2. Send a communication to the mailing list and slack channel about dropping support in future releases
  3. Drop support for Python 2 in Kubernetes Client v13.0.0

Update
This is planned for v18.0.0 now. A deprecation notice will be added to v17.0.0.

@booooh
Copy link

booooh commented Oct 15, 2020

With 12.0.0 being released, is this planned for the next release?

@palnabarun
Copy link
Member Author

@booooh -- Yes. We are planning to add a deprecation notice in the next release and completely remove in the release after that.

@palnabarun
Copy link
Member Author

Python 2 support had been dropped since Client Version v18.17.0a1 with v18.20.0 being the first stable release. 🎉

Ref: https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md#v18200

Hence, closing this.

@palnabarun
Copy link
Member Author

/remove-lifecycle frozen
/close

@k8s-ci-robot
Copy link
Contributor

@palnabarun: Closing this issue.

In response to this:

/remove-lifecycle frozen
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants