Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for no_proxy #1578

Closed
itaru2622 opened this issue Oct 18, 2021 · 1 comment · Fixed by #1579
Closed

add support for no_proxy #1578

itaru2622 opened this issue Oct 18, 2021 · 1 comment · Fixed by #1579
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@itaru2622
Copy link
Contributor

itaru2622 commented Oct 18, 2021

What is the feature and why do you need it:

current kubernetes-client/python(-base) support parameter for proxy but NOT no_proxy.
as the result, operator needs to set/unset proxy according to the target clusters.
it is somewhat bothering task because kubectl supports both proxy and no_proxy environment variables.

Describe the solution you'd like to see:

add 'no_proxy' parameter in kubernetes/client/configuration.py and support no_proxy just like kubectl.
sample value of no_proxy is below:

no_proxy = 'localhost,.local,127.0.0.0/8,.example.com'

the above format (including CIDR) is supported by requests.utils.should_bypass_proxies, and it maybe the same as no_proxy environment variable.

It also needs no_proxy support in kubernetes-client/python-base for k8s_exec and k8s_cp, etc.

@itaru2622 itaru2622 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 18, 2021
@itaru2622
Copy link
Contributor Author

cross reference to kubernetes-client/python-base#259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant