Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

add support for no_proxy #259

Closed
itaru2622 opened this issue Oct 18, 2021 · 0 comments · Fixed by #260
Closed

add support for no_proxy #259

itaru2622 opened this issue Oct 18, 2021 · 0 comments · Fixed by #260

Comments

@itaru2622
Copy link
Contributor

related to kubernetes-client/python#1578

What is the feature and why do you need it:

current kubernetes-client/python(-base) support parameter for proxy but NOT no_proxy.
as the result, operator needs to set/unset proxy according to the target clusters.
it is somewhat bothering task because kubectl supports both proxy and no_proxy environment variables.

Describe the solution you'd like to see:

add 'no_proxy' handling in stream/ws_client.py and support no_proxy just like kubectl.
sample value of no_proxy is below:

no_proxy = 'localhost,.local,127.0.0.0/8,.example.com'

the above format (including CIDR) is supported by requests.utils.should_bypass_proxies, and it maybe the same as no_proxy environment variable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant