This repository has been archived by the owner on Mar 13, 2022. It is now read-only.
add no_proxy support to websocket client #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/S
|
/assign @roycaihw |
yliaog
reviewed
Oct 18, 2021
stream/ws_client.py
Outdated
| @@ -457,6 +458,12 @@ def create_websocket(configuration, url, headers=None): | |||
| return websocket | |||
|
|
|||
| def websocket_proxycare(connect_opt, configuration, url, headers): | |||
| """ An internalfunction to be called in api-client when a websocket | |||
There was a problem hiding this comment.
s/internalfunction/internal function/
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: itaru2622, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds no_proxy handling in websocket client as described in kubernetes-client/python#1579
Which issue(s) this PR fixes:
Fixes #259
Special notes for your reviewer:
this PR uses new configuration parameter 'no_proxy' added by kubernetes-client/python#1579
Does this PR introduce a user-facing change?
mentioned in kubernetes-client/python#1579
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: