Cleanup ThreadPool with atexit rather than __del__ #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/S
This removes the __del__ function from the generated Python client, and replaces it with a cleanup function. When a ThreadPool is created, the cleanup function is registered with the atexit module. This PR also allows the client to be used as a context manager, which will automatically clean up after itself rather than having to wait til process exit. This fixes issue kubernetes-client#1037, where the API client could hang indefinitely at garbage collection.
fabianvf
force-pushed
the
fix-py3-hang
branch
from
9a5138a
to
18d21df
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
could you add a test that can run successfully with this fix, and would fail without the fix? |
k8s-ci-robot
added
size/M
|
/test |
fabianvf
force-pushed
the
fix-py3-hang
branch
from
c27391e
to
13dffb8
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianvf, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabianvf
pushed a commit
to fabianvf/python
that referenced
this pull request
Feb 11, 2020
Cleanup ThreadPool with atexit rather than __del__ (cherry picked from commit 0976d59)
fabianvf
pushed a commit
to fabianvf/python
that referenced
this pull request
Feb 11, 2020
Cleanup ThreadPool with atexit rather than __del__ (cherry picked from commit 0976d59)
fabianvf
pushed a commit
to fabianvf/python
that referenced
this pull request
Feb 11, 2020
Cleanup ThreadPool with atexit rather than __del__ (cherry picked from commit 0976d59)
This was referenced Feb 11, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 11, 2020
cherry-pick of #1073 to release-11.0: Fix python3 hang
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 11, 2020
cherry-pick of #1073 to release-12.0: Fix python3 hang
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 21, 2020
cherry-pick of #1073 to release-10.0: Fix python3 hang
Merged
palnabarun
added a commit
to palnabarun/python
that referenced
this pull request
Mar 12, 2020
palnabarun
added a commit
to palnabarun/python
that referenced
this pull request
Mar 12, 2020
palnabarun
added a commit
to palnabarun/python
that referenced
this pull request
Jun 22, 2020
The implementation and tests were already picked up by the upstream OpenAPI generator [here](OpenAPITools/openapi-generator#5094). Patching in the tests here for correctness and clarity. Reference: kubernetes-client#1073 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
palnabarun
added a commit
to palnabarun/python
that referenced
this pull request
Jun 22, 2020
The implementation and tests were already picked up by the upstream OpenAPI generator [here](OpenAPITools/openapi-generator#5094). Patching in the tests here for correctness and clarity. Reference: kubernetes-client#1073 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
palnabarun
added a commit
to palnabarun/python
that referenced
this pull request
Jul 16, 2020
The implementation and tests were already picked up by the upstream OpenAPI generator [here](OpenAPITools/openapi-generator#5094). Patching in the tests here for correctness and clarity. Reference: kubernetes-client#1073 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
palnabarun
added a commit
to palnabarun/python
that referenced
this pull request
Aug 19, 2020
The implementation and tests were already picked up by the upstream OpenAPI generator [here](OpenAPITools/openapi-generator#5094). Patching in the tests here for correctness and clarity. Reference: kubernetes-client#1073 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
abdul5497
pushed a commit
to abdul5497/python-dapp
that referenced
this pull request
Apr 1, 2024
The implementation and tests were already picked up by the upstream OpenAPI generator [here](OpenAPITools/openapi-generator#5094). Patching in the tests here for correctness and clarity. Reference: kubernetes-client/python#1073 Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
__del__function from the generated Python client,and replaces it with a
cleanupfunction. When aThreadPoolis created,the
cleanupfunction is registered with theatexitmodule.This PR also allows the client to be used as a context manager, which
will automatically clean up after itself rather than having to wait til
process exit.
This fixes #1037, where the API client could hang indefinitely at
garbage collection.