Enable leaderelection #1363
Enable leaderelection #1363
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/assign @yliaog |
|
the module kubernetes/base in this repo needs to be updated to have 'leaderelection' |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Invictus17, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -0,0 +1 @@ | |||
| base/leaderelection | |||
There was a problem hiding this comment.
looks like this is a text file, which caused the import failure. Instead this should be a symbolic link. See https://github.com/kubernetes-client/python/blob/master/kubernetes/dynamic as an example
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
There are failures in the 'kubernetes/e2e_test/test_client.py' test which I think are unrelated to my PR. |
|
close and reopen to rerun the ci tests |
|
/close |
|
@yliaog: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@yliaog: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Linking it to #1218