-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow optional list of YAML objects as param to create_from_yaml util #1403
Allow optional list of YAML objects as param to create_from_yaml util #1403
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @mecampbellsoup! |
/assign @roycaihw |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale Sorry for the late response. The change looks good to me. Please rebase and I will tag the PR /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mecampbellsoup, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@roycaihw rebased & fixed conflicts! |
/lgtm |
Description
Currently we are doing something like the following to use the
utils.create_from_yaml
helper:We have a YAML template file which we dynamically inject variables into, which is finally passed to the util function.
There is an extra read happening here that could/should be removed. Adding an optional param
yaml_objects
seemed like a safe, backwards-compatible approach.