-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop python 2 support #1468
drop python 2 support #1468
Conversation
@Priyankasaggu11929: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
db5f1fc
to
c49368b
Compare
Signed-off-by: Priyanka Saggu <priyankasaggu11929@gmail.com>
16986e3
to
4a2a030
Compare
Need advice here: https://travis-ci.org/github/kubernetes-client/python/jobs/771168725 I'm trying to update the From the
The
Thank you! |
7c1c0c3
to
81c65bf
Compare
- remove python2 from the .travis.yaml file - remove python2 from the tox.ini file - remove `-y` flag from isort command in update-pycodestle.sh script - fix sequence of module imports to fix faiing pycodestyle check in the following files: - examples/multiple_clusters.py - examples/pick_kube_config_context.py - examples/pod_config_list.py - testing coverage & codecov tests with python3 - testing `update-pycodestyle` for python v3.9 and arch ppc6le Signed-off-by: Priyanka Saggu <priyankasaggu11929@gmail.com>
81c65bf
to
6f09733
Compare
[Update] So far, I have done the following to remove Python 2 support:
With these much changes, the CI jobs are green so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove '[WIP]'
env: TOXENV=update-pycodestyle | ||
arch: ppc64le | ||
arch: ppc64le |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks there are extra spaces at the end, please remove them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the spaces. Thanks!
@@ -67,7 +67,7 @@ done | |||
|
|||
echo "--- applying isort" | |||
for SOURCE in $SOURCES; do | |||
isort -y $SOURCE | |||
isort $SOURCE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should have been called before with python3, not sure why there was no errors before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, there is no action required here, right?
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no action, just wondering if you know why there was no error before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were no previous test running update-pycodestyle.sh
script with python3.x versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, that explains it.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Priyankasaggu11929, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also, re-iterating over questions asked in this comment #1468 (comment) : Q 2: Do I require to add the Q 3: What's the difference between py3{5,6,7,8,9} & py3{5,6,7,8,9}-functional? |
sorry, missed your prior questions. Q3: functional has e2e tests, the commands to show the difference is here: Line 15 in 821618f
|
Thank you @yliaog. That was really helpful clarification. :) |
What type of PR is this?
/kind feature
/kind clean-up
What this PR does / why we need it:
The PR makes changes to drop support for Python 2 from the next release (v18.0.0). The changes includes:
Which issue(s) this PR fixes:
Fixes #1413
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Signed-off-by: Priyanka Saggu priyankasaggu11929@gmail.com