-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix replication controller pods delete in tests #1529
Conversation
Welcome @hedrox! |
/label tide/merge-method-squash |
/remove-label tide/merge-method-squash Sorry for the noise. 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@palnabarun I think the GH Actions ran and the tests passed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hedrox, palnabarun, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think the hold label kept the PR from being merged, and now the GH Actions need to be approved again. I will remove the hold after the GH Actions passed. Sorry for the delay. |
/unhold |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Tests that create Replication Controller objects don't clean pods upon deletion
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is the follow-up of the issue: kubernetes-client/python-base#242
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: