added configuration 'http_proxy' to allow the usage of a proxy #206
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 9 9
Lines 681 681
=======================================
Hits 644 644
Misses 37 37Continue to review full report at Codecov.
|
|
LGTM. is it possible to add a test for this? |
k8s-ci-robot
added
cncf-cla: yes
|
@don41382 thanks for the PR. If you don't have time to figure out the test, let me know and I can look into adding a test if possible. |
|
@mbohlool sorry for the delayed response. I actually not sure how to test this. I am not a big python programmer. If you could show me how I would appreciate this. |
|
You can use some mock libraries but that I am not sure what is the best practice in python too. We can merge this without test. Thanks. |
kubernetes/client/configuration.py
Outdated
| @@ -89,6 +89,9 @@ def __init__(self): | |||
| # Set this to True/False to enable/disable SSL hostname verification. | |||
| self.assert_hostname = None | |||
|
|
|||
| # http proxy setting | |||
| self.http_proxy = None | |||
There was a problem hiding this comment.
minor: Can you rename this to http_proxy_url to self-document the type?
|
I just added a minor comment. Will merge after you address it. please stash new changes in the existing commit. Thanks. |
|
LGTM. Please |
|
@don41382 Sorry. things are moving around in the client because of a required restructuring of the client. You need to send this change to https://github.com/kubernetes-client/python-base now. |
|
as it was my fault moving things around while you were waiting for this to merge, this is an script to do the pull request automatically, just set your github username and make sure you have # make sure you have hub tool installed from here https://hub.github.com/
# run this in a temp folder
export GITHUB_USER=YOUR_GITHUB_USER
git clone https://github.com/kubernetes-client/python-base
cd python-base
hub fork
curl -o patch.diff https://patch-diff.githubusercontent.com/raw/kubernetes-incubator/client-python/pull/206.patch
sed -i'' "s.kubernetes/client/..g" patch.diff
git apply patch.diff
git commit -m "added configuration 'http_proxy' to allow the usage of a proxy"
git push $GITHUB_USER master
hub pull-request |
|
closing in favor of kubernetes-client/python-base#8 |
Leader Election issue kubernetes-client#434
No description provided.