Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add more assertions in e2e tests #2128

Merged
merged 3 commits into from
Oct 16, 2023
Merged

test: add more assertions in e2e tests #2128

merged 3 commits into from
Oct 16, 2023

Conversation

Ananya2001-an
Copy link
Member

What this PR does / why we need it:

added more assertions for the e2e tests

Does this PR introduce a user-facing change?

No

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 22, 2023
@Ananya2001-an
Copy link
Member Author

@yliaog can you rerun the tests on this one? thanks :)

@Ananya2001-an
Copy link
Member Author

@yliaog fixed test fail...kindly rerun the tests again, thanks!

@Ananya2001-an
Copy link
Member Author

Hey @yliaog @roycaihw will you be both willing to sponsor me for kubernetes-client org membership? I have been contributing to the python and javascript clients and I would love to work more on them :) you can take a look at my merged PRs so far:

kubernetes-client/javascript#1254
#2122
#2124
kubernetes/website#43115

@roycaihw
Copy link
Member

roycaihw commented Oct 9, 2023

/assign @yliaog

@yliaog
Copy link
Contributor

yliaog commented Oct 9, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ananya2001-an, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@Ananya2001-an
Copy link
Member Author

Also downgraded codecov action version to v3 since tests were failing... (v4 not found)

@yliaog
Copy link
Contributor

yliaog commented Oct 10, 2023

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 10, 2023
@Ananya2001-an
Copy link
Member Author

Hey @roycaihw can we merge this?

@Ananya2001-an Ananya2001-an mentioned this pull request Oct 14, 2023
Closed
9 tasks
@yliaog
Copy link
Contributor

yliaog commented Oct 16, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 36cfbe6 into kubernetes-client:master Oct 16, 2023
10 checks passed
@Ananya2001-an Ananya2001-an deleted the test-add-asserts branch October 17, 2023 02:53
dirrao pushed a commit to dirrao/python that referenced this pull request Nov 28, 2023
@k8s-ci-robot
Merge pull request kubernetes-client#2128 from Ananya2001-an/test-add…
fe1c27d 
…-asserts

test: add more assertions in `e2e tests`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ananya2001-an @roycaihw @yliaog @k8s-ci-robot