-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pick proxy from kube_config #2182
base: master
Are you sure you want to change the base?
pick proxy from kube_config #2182
Conversation
Welcome @kwibus! |
/assign |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@roycaihw any chance we could look at this? I can lend a hand for testing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fabianvf, kwibus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What type of PR is this?
/kind feature
What this PR does / why we need it:
kubeconfig support the option proxy-url .
This is option is ignored by this client. and people have trouble to configer there proxy #1967
This pull request will use that option to set
kubernetes.client.load_kube_config()' to set
kubernetes.client.configuration.proxy`Which issue(s) this PR fixes:
Fixes #2183
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: