Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable binary support for WSClient #2194

Merged

Commits on Feb 28, 2024

  1. Enable binary support for WSClient

    Currently, under python 3, the WSClient decodes all data via UTF-8. This
    will break, e.g. capturing the stdout of tar or gzip.
    This adds a new 'binary' kwarg to the WSClient class and websocket_call
    function. If this is set to true, then the decoding will not happen, and
    all channels will be interpreted as binary.
    This does raise a slight complication, as the OpenAPI-generated client
    will convert the output to a string, no matter what, which it ends up
    doing by (effectively) calling repr(). This requires a bit of magic to
    recover the orignial bytes, and is inefficient. However, this is only
    the case when using the default _preload_content=True, setting this to
    False and manually calling read_all or read_channel, this issue does not
    arise.
    meln5674 committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    488518d View commit details
    Browse the repository at this point in the history