-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove some six usage #2224
base: master
Are you sure you want to change the base?
remove some six usage #2224
Conversation
grep 'six.iteritems(self.openapi_types)' -rl | while read f do sed -i 's|six.iteritems(self.openapi_types)|self.openapi_types.items()|' $f done pyflakes3 . | grep "'six' imported but unused" | cut -d: -f1 | while read f do sed -i '/^import six$/d' $f done
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The committers listed above are authorized under a signed CLA. |
Welcome @a-detiste! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: a-detiste The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -13,7 +13,6 @@ | |||
import pprint | |||
import re # noqa: F401 | |||
|
|||
import six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is generated by openapi-generator. The change needs to be made upstream. Otherwise the change will be override when we re-generate the client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think it's already gone. OpenAPITools/openapi-generator#16675
Wait & see
/kind cleanup
six was only needed to also support Python2 with the same codebase.
https://wiki.debian.org/Python3-six-removal
I will continue if this first one succeeds.