Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in 'host configuration' #2225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Typo in 'host configuration' #2225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions kubernetes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ configuration.api_key['authorization'] = 'YOUR_API_KEY'
# Defining host is optional and default to http://localhost
configuration.host = "http://localhost"

# Defining host is optional and default to http://localhost
configuration.host = "http://localhost"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to be generated: https://github.com/kubernetes-client/python/commits/master/kubernetes/README.md. Perhaps this comes from the upstream openapi-generator?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to git blame, this part of README.md ( lines 60 and 61) was added by OpenAPI generator v4.3.0, but by mistake, lines 63 and 64 were added by Yu Liao when updating to version 1.26.
although it was written 4 years ago by OpenAPI generator.

here is the screenshot :

image

# Enter a context with an instance of the API kubernetes.client
with kubernetes.client.ApiClient(configuration) as api_client:
# Create an instance of the API class
Expand Down