Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented out rest_urllib_headers.diff as it caused AttributeError: #2234

Merged
merged 1 commit into from
May 21, 2024

Conversation

yliaog
Copy link
Contributor

@yliaog yliaog commented May 21, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels May 21, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2024
@yliaog
Copy link
Contributor Author

yliaog commented May 21, 2024

/assign @roycaihw

@yliaog
Copy link
Contributor Author

yliaog commented May 21, 2024

https://github.com/kubernetes-client/python/actions/runs/9181232574/job/25247484879#step:7:289

kubernetes/client/rest.py:238: in request
raise ApiException(http_resp=r)


def __init__(self, status=None, reason=None, http_resp=None):
    if http_resp:
        self.status = http_resp.status
        self.reason = http_resp.reason
        self.body = http_resp.data
      self.headers = http_resp.headers

E AttributeError: 'RESTResponse' object has no attribute 'headers'

kubernetes/client/exceptions.py:91: AttributeError

@roycaihw
Copy link
Member

/lgtm
/approve

IIUC the patch was never used, therefore we never hit the issue, right?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yliaog
Copy link
Contributor Author

yliaog commented May 21, 2024

yes, the patch was added recently after the last release cut.

@k8s-ci-robot k8s-ci-robot merged commit e1fce8d into kubernetes-client:master May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants