Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use server_side_apply to utils.create_from_yaml #2252

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Jun 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allows utils.create_from_yaml functions to optionally use server side apply. This is a feature that has been requested numerous times. It will allow applying a manifest more than once without throwing an error or updating manifests and reapplying (similar to how kubectl apply works).

Which issue(s) this PR fixes:

Fixes #2251
Addresses #2030
Part of #1737

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added the ability to use the optional `apply` parameter for functions within the `utils.create_from_yaml` submodule. This allows these functions to optionally use the `DynamicClient.server_side_apply` function to apply yaml manifests.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[Usage]: create_from_yaml(kubernetes_client, manifest, apply=True)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 27, 2024
Copy link

linux-foundation-easycla bot commented Jun 27, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dcmcand!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 27, 2024
@dcmcand
Copy link
Contributor Author

dcmcand commented Jul 2, 2024

/assign @yliaog @roycaihw

@dcmcand
Copy link
Contributor Author

dcmcand commented Jul 8, 2024

@yliaog, is there anything I can do to help get this looked at?

@dcmcand
Copy link
Contributor Author

dcmcand commented Jul 24, 2024

@yliaog @roycaihw Is there anything I can do to help get this looked at?

@troll-warlord
Copy link

When should i expect this to be released?

@dcmcand dcmcand marked this pull request as draft August 5, 2024 13:23
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
@dcmcand dcmcand marked this pull request as ready for review August 5, 2024 13:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
@marcelovilla
Copy link

Hey @yliaog @roycaihw! We could use this feature in our project. Are you planning to review this anytime soon? Thanks for all the work!

@yliaog
Copy link
Contributor

yliaog commented Sep 12, 2024

sure, i'll take a look in the next couple of days.

@yliaog
Copy link
Contributor

yliaog commented Sep 16, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcmcand, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 18fe668 into kubernetes-client:master Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow utils.create_from_yaml to use server side apply
6 participants