Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Setup.py error on Windows #676 #766

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

Sai-Adarsh
Copy link
Contributor

Initial CommitFixes Setup.py error on Windows, added shell script to check python environment, prints the python version, copy files from /kubernetes/base to /kubernetes/ and finally runs python setup.py install issue #676

Initial Commit
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2019
@Sai-Adarsh
Copy link
Contributor Author

/assign @micw523

@Sai-Adarsh
Copy link
Contributor Author

/assign @roycaihw

@Sai-Adarsh
Copy link
Contributor Author

/assign @yliaog

@Sai-Adarsh
Copy link
Contributor Author

Sai-Adarsh commented Feb 20, 2019

@yliaog @roycaihw @micw523 closed the previous PR on the same issue #676 , commits are squashed in this PR and changes are up-to-date.

@micw523
Copy link
Contributor

micw523 commented Feb 20, 2019

Um you didn't have to close the previous PR but /lgtm

@micw523
Copy link
Contributor

micw523 commented Feb 20, 2019

/lgtm
Come on, bot

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2019
@Sai-Adarsh
Copy link
Contributor Author

@micw523 cool.

@Sai-Adarsh
Copy link
Contributor Author

@yliaog could you approve the PR

@yliaog
Copy link
Contributor

yliaog commented Feb 20, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sai-Adarsh, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit fcda6fe into kubernetes-client:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants