-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding option to send number of retries to override default value of 3. #780
Conversation
/assign @lavalamp |
/assign @roycaihw |
these files are generated by swagger-codegen. The changes will be overwritten when we regenerate the client you could send a PR to swagger-codegen to fix it upstream, and update the patch to carry it in the meantime |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chowmean If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Created the PR in upstream. swagger-api/swagger-codegen#9284 |
@roycaihw by update the patch to carry it in the meantime, did you mean this? |
@chowmean do you mind filing a PR for https://github.com/OpenAPITools/openapi-generator as well? I believe eventually we want to replace Swagger Codegen with OpenAPI Generator in this project: kubernetes-client/gen#93 |
@wing328 sure will do it.. |
Created the PR. OpenAPITools/openapi-generator#2460 |
UPDATE: OpenAPITools/openapi-generator#2460 has been merged into master. Thanks for the contribution by @chowmean |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Thanks for working on this! The change will be included in this project when kubernetes-client/gen#97 is in place |
This PR addresses #652
Adding option in configuration and rest client object to send number of retries value to override the default value of 3 in urllib3.