-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate extensions/v1beta1 deployment #888
Conversation
micw523
commented
Jul 23, 2019
- Fix a test with duplicate name introduced in Add method to dynamically set namespace in yaml files #782.
- Deprecate extensions/v1beta1 deployment. (Fix and Update Existing Examples #884, comment)
- Update examples to use up-to-date nginx (Fix and Update Existing Examples #884, comment)
examples/create_deployment.py
Outdated
@@ -27,7 +27,7 @@ def main(): | |||
|
|||
with open(path.join(path.dirname(__file__), "nginx-deployment.yaml")) as f: | |||
dep = yaml.safe_load(f) | |||
k8s_beta = client.ExtensionsV1beta1Api() | |||
k8s_beta = client.AppsV1Api() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename k8s_beta
to something that makes more sense, e.g. apps_v1
. Otherwise lgtm
Found out that |
@micw523 let's do all the extensions/v1beta1 change in one PR |
@roycaihw done. Although |
template: | ||
metadata: | ||
labels: | ||
app: nginx | ||
spec: | ||
containers: | ||
- name: nginx | ||
image: nginx:1.7.9 | ||
image: nginx:1.15.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything wrong with using latest
so we don't have to keep bumping it in the future? Obviously not good practice but given it's an example I think it should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm keeping it on pace with https://k8s.io/examples/controllers/nginx-deployment.yaml. Otherwise I don't have a good reason :/
/assign @roycaihw |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: micw523, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deprecate extensions/v1beta1 deployment (cherry picked from commit 41971cc)