Add a test for custom object operations #930
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| plural='foos', | ||
| namespace='default', | ||
| name=name, | ||
| body={}) |
There was a problem hiding this comment.
do you want to check the resp? does it succeed?
There was a problem hiding this comment.
added .metadata.name check to make sure that the response is a CRD, not a metav1.Status
also added a commit to make the CRD deserializer usable before we fix the upstream openapi spec: kubernetes/kubernetes#64996
| @@ -101,8 +101,6 @@ def conditions(self, conditions): | |||
| :param conditions: The conditions of this V1beta1CustomResourceDefinitionStatus. | |||
| :type: list[V1beta1CustomResourceDefinitionCondition] | |||
| """ | |||
| if conditions is None: | |||
| raise ValueError("Invalid value for `conditions`, must not be `None`") | |||
There was a problem hiding this comment.
this is generated, and will be overwritten in next release, right?
There was a problem hiding this comment.
yes, the proper fix will come in 1.16 kubernetes/kubernetes#64996
somehow in the test, the response is deserialized into a dict instead of a CRD object, which causes the attribute assertion to fail. Perhaps this workaround isn't ideal either. I will abandon this pull and verify the CR patch methods manually in the next couple of releases
/close
|
@roycaihw: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pick the test from #886 to prevent breaking change like #866 from happening