Create snapshotclass based on snapshotter sidecar version

[ggriffiths]

Signed-off-by: Grant Griffiths grant@portworx.com

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
We were deploying the latest snapshotclass for on-kubernetes-master tests, regardless of the csi-snapshotter version. Now we'll apply the snapshotclass depending on the sidecar version.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[ggriffiths]

/test pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-master

[ggriffiths]

/test pull-kubernetes-csi-csi-driver-host-path-1-15-on-kubernetes-master

[ggriffiths]

/assign @msau42

[msau42]

this is sort of strange because the snapshotclass should live with the driver like storageclass does.

Another option I was thinking is to disable snapshots when the deployment version doesn't match the kubernetes version (before 1.17). Because it was an alpha feature so there's no guarantees for cross version compatibility.

[ggriffiths]

Hmm ok, I'm unfamiliar with how to skip the snapshot tests. If we just don't apply a snapshotclass, will that cause the tests to be skipped?

[msau42]

while it was alpha, we only run the snapshot tests when the cluster and deployment version matched, and also only for the latest version. So I think for logic < 1.17, we can make this assumption.

[ggriffiths]

1.17 test flaked I believe:

    should support restarting containers using directory as subpath [Slow] [It]
    /home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/storage/testsuites/subpath.go:315
    Dec 10 21:59:02.741: while waiting for container to stabilize
      
    Unexpected error:
        <*errors.errorString | 0xc0000d9890>: {
            s: "timed out waiting for the condition",
        }
        timed out waiting for the condition
    occurred

/test pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-1-17

[msau42]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggriffiths, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment