Update release tool #234
Merged
Update release tool #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/retest |
|
/assign @xing-yang @pohly |
|
/retest |
1 similar comment
|
/retest |
|
We'll have to step through the full test log to determine where it fails with a non-zero exit code. The JUnit file doesn't record any failed test. I'm still out for another week, though. Another comment: please re-do the release-tools update with |
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout 9318c6c cloud build: double the timeout, now 1 hour 4ab8b15 use the tag to replace commit of csi-test 5d74e45 change the csi-test import path to v4 7dcd0a9 upgrade csi-test to v4.0.2 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name c3a9662 allow export image name and registry name git-subtree-dir: release-tools git-subtree-split: 2bb7525
fengzixu
force-pushed
the
update-release-tool
branch
from
2765da1 to
3f7d451
Compare
|
Looks like appending That change had been tested (kubernetes-csi/csi-release-tools#117 (comment) -> #210) but something must have gone wrong when testing that PR because the prow.sh change is broken without any obvious test failure. @fengzixu Please fix the issue in this PR and then port it back to csi-release-tools. I think you can simply use |
k8s-ci-robot
added
size/M
fengzixu
force-pushed
the
update-release-tool
branch
from
c3a7e56 to
1c12158
Compare
k8s-ci-robot
added
size/S
I think even if I didn't add |
|
Instead of |
|
@pohly I two issues in prow.sh script is
In that case, I modified the logic in prow.sh, we need to build binary file of csi-sanity and move it to the target directory git_checkout "${CSI_PROW_SANITY_REPO}" "${GOPATH}/src/${CSI_PROW_SANITY_PACKAGE_PATH}" "${CSI_PROW_SANITY_VERSION}" --depth=1 || die "checking out csi-sanity failed"
cd "${GOPATH}/src/${CSI_PROW_SANITY_PACKAGE_PATH}/cmd/csi-sanity" && go build || die "building csi-sanity failed"
mv ./csi-sanity "${CSI_PROW_WORK}"This change above has been tested in https://github.com/kubernetes-csi/csi-driver-host-path/pull/210/files Fixing PR: https://github.com/kubernetes-csi/csi-release-tools/pull/128/files @pohly @xing-yang |
pohly
requested changes
Jan 19, 2021
release-tools/prow.sh
Outdated
| git_checkout "${CSI_PROW_SANITY_REPO}" "${GOPATH}/src/${CSI_PROW_SANITY_IMPORT_PATH}" "${CSI_PROW_SANITY_VERSION}" --depth=1 || die "checking out csi-sanity failed" | ||
| run_with_go "${CSI_PROW_GO_VERSION_SANITY}" go test -c -o "${CSI_PROW_WORK}/csi-sanity" "${CSI_PROW_SANITY_IMPORT_PATH}/cmd/csi-sanity" || die "building csi-sanity failed" | ||
| git_checkout "${CSI_PROW_SANITY_REPO}" "${GOPATH}/src/${CSI_PROW_SANITY_PACKAGE_PATH}" "${CSI_PROW_SANITY_VERSION}" --depth=1 || die "checking out csi-sanity failed" | ||
| run_with_go "${CSI_PROW_GO_VERSION_SANITY}" go test -c -o "${CSI_PROW_WORK}/csi-sanity" "${CSI_PROW_SANITY_PACKAGE_PATH}/cmd/csi-sanity" || die "building csi-sanity failed" |
There was a problem hiding this comment.
Sat Jan 16 11:45:07 UTC 2021 go1.15.5 $ go test -c -o /home/prow/go/pkg/csiprow.IW3LnBgFPK/csi-sanity github.com/kubernetes-csi/csi-test/cmd/csi-sanity
go: finding module for package github.com/kubernetes-csi/csi-test/cmd/csi-sanity
go: downloading github.com/kubernetes-csi/csi-test v1.1.1
go: downloading github.com/kubernetes-csi/csi-test v2.2.0+incompatible
go: found github.com/kubernetes-csi/csi-test/cmd/csi-sanity in github.com/kubernetes-csi/csi-test v2.2.0+incompatible
go: downloading gopkg.in/yaml.v2 v2.2.8
go: downloading google.golang.org/grpc v1.34.0
go: downloading github.com/onsi/ginkgo v1.11.0
go: downloading github.com/google/uuid v1.1.2
go: downloading github.com/onsi/gomega v1.7.0
go: downloading github.com/container-storage-interface/spec v1.3.0
go: downloading golang.org/x/net v0.0.0-20201209123823-ac852fbbde11
go: downloading github.com/golang/protobuf v1.4.3
go: downloading google.golang.org/protobuf v1.25.0
go: downloading github.com/hpcloud/tail v1.0.0
go: downloading gopkg.in/fsnotify.v1 v1.4.7
go: downloading golang.org/x/text v0.3.4
go: downloading google.golang.org/genproto v0.0.0-20201209185603-f92720507ed4
go: downloading golang.org/x/sys v0.0.0-20201207223542-d4d67f95c62d
go: downloading gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7
I'm pretty sure that this ignored the source that was checked out earlier. What we need to do instead is check out the source, then inside that source code directory build with a relative package path:
go build -o "${CSI_PROW_WORK}/csi-sanity" ./cmd/csi-sanity
There was a problem hiding this comment.
Sorry, I'm getting confused by the number of open PRs for this.
I see that you switched to go build + mv in #210. A better solutution would be to use go build -o <target path>.
There was a problem hiding this comment.
#210 is for testing if v4.0.2 can satisfy the requirement of new capability
#234 is for updating release-tool to host-path driver
But, now, we found a bug in csi-release-tool, that's reason why I submit a new PR kubernetes-csi/csi-release-tools#128
Those PRs should be merge based on the order as below
- fix: fix a bug of building csi-sanity csi-release-tools#128
- Run git subtree command to update Update release tool #234
- Rebase change of release-tool and merge feature: support external-health-monitor #210
fengzixu
force-pushed
the
update-release-tool
branch
from
def906b to
3fbeb2b
Compare
|
/test pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-1-19 |
8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master 1c94220 fix: fix a bug of csi-sanity a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate dbd8967 verify-boilerplate.sh: fix path to script 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks ad29307 Make the spelling and boilerplate checks optional 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests 48186eb Fix spelling and boilerplate errors 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests 981be3f Adding spelling and boilerplate checks. git-subtree-dir: release-tools git-subtree-split: 8fdf0f7
fengzixu
force-pushed
the
update-release-tool
branch
from
3fbeb2b to
dc3a2b6
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fengzixu, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
xing-yang
added a commit
to xing-yang/csi-driver-host-path
that referenced
this pull request
Nov 27, 2023
f8c8cc4 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bf Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c465088 pull-test.sh: avoid "git subtree pull" error 7b175a1 Update csi-test version to v5.2.0 987c90c Update go version to 1.21 to match k/k 2c625d4 Add script to generate patch release notes f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd53 Bump csi-driver-host-path version up to v1.12.0 984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e remove windows 20H2 build since it's EOL long time ago 670bb0e Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e78 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76 Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd2821 Update cloudbuild image with go 1.20.5 1df23db Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e Add ginkgo timeout to e2e tests to help catch any stuck tests 2b8b80e fixing some codespell errors c10b678 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec chore: adopt kubernetes recommand label b055535 Header bd0a10b typo c39d73c Add comments f6491af Script to verify EOL sidecar version 901bcb5 Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: f8c8cc4
Merged
TerryHowe
pushed a commit
to TerryHowe/csi-driver-host-path
that referenced
this pull request
Oct 17, 2024
fixed broken links of testgrid dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
After this pr was merged, we should also update the csi-test version for csi-driver-host-path.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: