-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: propagate default host configuration files to csi node #521
feat: propagate default host configuration files to csi node #521
Conversation
|
Welcome @vlboiko! |
Hi @vlboiko. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vlboiko could you fix the yaml format issue? thanks. https://github.com/kubernetes-csi/csi-driver-nfs/actions/runs/6540118621/job/17762928651?pr=521 |
f1146ef
to
1e1dfd9
Compare
1e1dfd9
to
fda9ff2
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, vlboiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This pull request introduces new feature that can be configured using
--set feature.propagateHostMountOptions=true
flag. It mounts the/etc/nfsmount.conf
file and the/etc/nfsmount.conf.d
k8s host directory onto the mirrored locations of the CSI node. This enables the utilization of default host mount options for NFS provisioning.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: