Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Fix unresolvable indirect dependency #528

Merged

Conversation

pierreprinetti
Copy link
Contributor

Fix go list -mod=readonly -m all by adding a replace for k8s.io/dynamic-resource-allocation that points to the Kubernetes version currently in use.

The packages is not used here, but making the dependency resolvable makes the go toolchain happy.

cf.: https://github.com/kubernetes/kubernetes/blob/4b48ab1fdbdeee3568790e44bea55ea719205025/go.mod#L265

none

Fix `go list -mod=readonly -m all` by adding a replace for
`k8s.io/dynamic-resource-allocation` that points to the
Kubernetes version currently in use.

The packages is not used here, but making the dependency resolvable
makes the go toolchain happy.

cf.: https://github.com/kubernetes/kubernetes/blob/4b48ab1fdbdeee3568790e44bea55ea719205025/go.mod#L265
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@dulek
Copy link
Contributor

dulek commented Oct 23, 2023

/lgtm

@k8s-ci-robot
Copy link
Contributor

@dulek: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link

LGTM

@pierreprinetti
Copy link
Contributor Author

/assign jsafrane

@dulek
Copy link
Contributor

dulek commented Oct 25, 2023

/lgtm

@k8s-ci-robot
Copy link
Contributor

@dulek: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Oct 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2023
@jsafrane
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 72c8ff7 into kubernetes-csi:master Oct 25, 2023
11 checks passed
@pierreprinetti pierreprinetti deleted the fix_dynamic_allocation branch October 26, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants