-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: Fix unresolvable indirect dependency #528
go.mod: Fix unresolvable indirect dependency #528
Conversation
Fix `go list -mod=readonly -m all` by adding a replace for `k8s.io/dynamic-resource-allocation` that points to the Kubernetes version currently in use. The packages is not used here, but making the dependency resolvable makes the go toolchain happy. cf.: https://github.com/kubernetes/kubernetes/blob/4b48ab1fdbdeee3568790e44bea55ea719205025/go.mod#L265
/lgtm |
@dulek: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM |
/assign jsafrane |
/lgtm |
@dulek: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix
go list -mod=readonly -m all
by adding a replace fork8s.io/dynamic-resource-allocation
that points to the Kubernetes version currently in use.The packages is not used here, but making the dependency resolvable makes the go toolchain happy.
cf.: https://github.com/kubernetes/kubernetes/blob/4b48ab1fdbdeee3568790e44bea55ea719205025/go.mod#L265