Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: driver name in storage class helm configure #807

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: driver name in storage class helm configure #807

merged 1 commit into from
Dec 2, 2024

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: driver name in storage class helm configure

Which issue(s) this PR fixes:

Fixes #806

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: driver name in storage class helm configure

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2024
@coveralls
Copy link

coveralls commented Dec 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12112875593

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.156%
Totals Coverage Status
Change from base Build 12092585761: 0.0%
Covered Lines: 941
Relevant Lines: 1204
💛 - Coveralls

@andyzhangx
fix: driver name in storage class helm configure
59adb7c 
fix: driver name in storage class helm configure
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit c992d80 into kubernetes-csi:master Dec 2, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

@gnufied gnufied Awaiting requested review from gnufied

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StorageClass provisioner in Helm Chart is not configurable
3 participants
@andyzhangx @k8s-ci-robot @coveralls