-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move integration tests into github workflows #105
move integration tests into github workflows #105
Conversation
Welcome @boddumanohar! |
Hi @boddumanohar. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 242739408
💛 - Coveralls |
/ok-to-test |
692f757
to
83450c4
Compare
Update: removed the integration tests from .travis.yml. Since these will run for Github workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution
@@ -0,0 +1,49 @@ | |||
name: Go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you move all test pipelines in this file to go.yml
? thanks.
.travis.yml
Outdated
@@ -9,32 +9,6 @@ go: | |||
|
|||
jobs: | |||
include: | |||
- stage: test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep .travis.yml
for a while, make sure new test pipeline in github workflow always works.
83450c4
to
5272aff
Compare
5272aff
to
d783d25
Compare
Update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, boddumanohar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Currently
/kind cleanup
What this PR does / why we need it:
Currently half of the tests are in GitHub workflows and few others in travis.yml. With this change, except e2e tests, everything else be moved to GitHub workflows.
Which issue(s) this PR fixes:
Fixes #54
Requirements:
Special notes for your reviewer:
Release note: