Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup e2e tests in github actions #128

Merged
merged 1 commit into from
Oct 5, 2020
Merged

setup e2e tests in github actions #128

merged 1 commit into from
Oct 5, 2020

Conversation

boddumanohar
Copy link
Contributor

What type of PR is this?
This PR adds setting up e2e testing in GitHub action using kind. Kind helps us do e2e tests on various Kubernetes versions and it's also pretty lightweight.

What this PR does / why we need it:
helps in our efforts to move tests to Github actions.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @boddumanohar. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2020
@boddumanohar boddumanohar mentioned this pull request Oct 3, 2020
Closed
4 tasks
@coveralls
Copy link

coveralls commented Oct 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 289056067

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.658%
Totals Coverage Status
Change from base Build 285530136: 0.0%
Covered Lines: 625
Relevant Lines: 713
💛 - Coveralls

andyzhangx
andyzhangx reviewed Oct 3, 2020
View reviewed changes
test/utils/deploy-kind.sh
curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.9.0/kind-linux-amd64 && chmod +x ./kind && sudo mv ./kind /usr/local/bin/kind
curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.18.8/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin/

sudo kind create cluster --image kindest/node:$KUBERNETES_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does kind supports windows cluster?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Kind currently only supports Linux nodes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kubernetes.slack.com/archives/CEKK1KTN2/p1601710766100300

andyzhangx
andyzhangx reviewed Oct 5, 2020
View reviewed changes
test/utils/deploy-kind.sh Outdated

# Setup and download kind
curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.9.0/kind-linux-amd64 && chmod +x ./kind && sudo mv ./kind /usr/local/bin/kind
curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/v1.18.8/bin/linux/amd64/kubectl && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.18.8 --> $KUBERNETES_VERSION

test/utils/deploy-kind.sh Outdated
sudo chown -R $USER: $HOME/.kube/
sudo kind get kubeconfig > $KUBECONFIG

# setup samba server and deploy SMB CSI driver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo "setup samba server and deploy SMB CSI driver ..."

.github/workflows/ubuntu.yml Outdated
@@ -46,6 +46,12 @@ jobs:
make
make sanity-test

- name: e2e tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you move this to a standalone yml file, could be ubuntu-e2e.yml

andyzhangx
andyzhangx reviewed Oct 5, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2020
andyzhangx
andyzhangx approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 35a66d9 into kubernetes-csi:master Oct 5, 2020
@boddumanohar boddumanohar mentioned this pull request Jun 3, 2021
Closed
andyzhangx pushed a commit to andyzhangx/csi-driver-smb that referenced this pull request May 1, 2022
@k8s-ci-robot
Merge pull request kubernetes-csi#128 from fengzixu/master
8fdf0f7 
fix: fix a bug of building csi-sanity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boddumanohar @k8s-ci-robot @coveralls @andyzhangx