chore: upgrade CSIDriver to v1 from v1beta1

[dr0pdb]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
upgrades CSIDriver to v1 from the deprecated v1beta1 api group

Which issue(s) this PR fixes:

Fixes #177

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:
N/A

Release note:

none

[k8s-ci-robot]

Welcome @dr0pdb!

It looks like this is your first PR to kubernetes-csi/csi-driver-smb 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-smb has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @dr0pdb. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dr0pdb
To complete the pull request process, please assign andyzhangx after the PR has been reviewed.
You can assign the PR to them by writing /assign @andyzhangx in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/ok-to-test

[coveralls]

Pull Request Test Coverage Report for Build 439948437

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 87.291%

---

Totals
Change from base Build 433835804:	0.0%
Covered Lines:	625
Relevant Lines:	716

---

💛 - Coveralls

[dr0pdb]

#7 [3/4] RUN clean-install ca-certificates cifs-utils util-linux e2fsprogs mount udev xfsprogs
#7 sha256:e413fb7825707e78d8da96f36053cbfcb0d4125cd80a60236ba15507ec8b7e59
#7 0.326 /bin/sh: 0: Can't open clean-install
#7 ERROR: executor failed running [/dev/.buildkit_qemu_emulator /bin/sh -c clean-install ca-certificates cifs-utils util-linux e2fsprogs mount udev xfsprogs]: exit code: 127
------
 > [3/4] RUN clean-install ca-certificates cifs-utils util-linux e2fsprogs mount udev xfsprogs:
------

[andyzhangx]

/retest

[andyzhangx]

#7 [3/4] RUN clean-install ca-certificates cifs-utils util-linux e2fsprogs mount udev xfsprogs
#7 sha256:e413fb7825707e78d8da96f36053cbfcb0d4125cd80a60236ba15507ec8b7e59
#7 0.326 /bin/sh: 0: Can't open clean-install
#7 ERROR: executor failed running [/dev/.buildkit_qemu_emulator /bin/sh -c clean-install ca-certificates cifs-utils util-linux e2fsprogs mount udev xfsprogs]: exit code: 127
------
 > [3/4] RUN clean-install ca-certificates cifs-utils util-linux e2fsprogs mount udev xfsprogs:
------

this is a flacky test, I filed an issue here: #179, could you take a look later? thanks.

[dr0pdb]

sure, I'll take a look.

[dr0pdb]

/retest

[dr0pdb]

/retest

[andyzhangx]

the arm64 image build error should be fixed by #174

[andyzhangx]

/retest

[dr0pdb]

@andyzhangx How to upgrade the Kubernetes version on e2e tests?

It is failing with

Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "CSIDriver" in version "storage.k8s.io/v1"
helm.go:81: [debug] unable to recognize "": no matches for kind "CSIDriver" in version "storage.k8s.io/v1"

This is because CSIDriver object became GA in Kubernetes 1.18

It seems like e2e test runs Kubernetes 1.17.16

2020/12/25 09:04:34 e2e.go:474: Cluster nodes:
k8s-agentpool1-42488232-vmss000000   Ready   agent    44s   v1.17.16
k8s-agentpool1-42488232-vmss000001   Ready   agent    44s   v1.17.16
k8s-master-42488232-0                Ready   master   44s   v1.17.16

[andyzhangx]

@andyzhangx How to upgrade the Kubernetes version on e2e tests?

It is failing with

Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "CSIDriver" in version "storage.k8s.io/v1"
helm.go:81: [debug] unable to recognize "": no matches for kind "CSIDriver" in version "storage.k8s.io/v1"

This is because CSIDriver object became GA in Kubernetes 1.18

It seems like e2e test runs Kubernetes 1.17.16

2020/12/25 09:04:34 e2e.go:474: Cluster nodes:
k8s-agentpool1-42488232-vmss000000   Ready   agent    44s   v1.17.16
k8s-agentpool1-42488232-vmss000001   Ready   agent    44s   v1.17.16
k8s-master-42488232-0                Ready   master   44s   v1.17.16

thanks for the investigation, I think let's hold this PR for a few months since v1.17 is still supported now.

[dr0pdb]

sure.

/hold

[andyzhangx]

/test pull-csi-driver-smb-integration

[dr0pdb]

Same error.

helm.go:81: [debug] unable to recognize "": no matches for kind "CSIDriver" in version "storage.k8s.io/v1"

Kubernetes version is still 1.17.16. We need version 1.18 or above

print out all nodes status ...
NAME                                 STATUS   ROLES    AGE     VERSION    INTERNAL-IP    EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION     CONTAINER-RUNTIME
k8s-agentpool1-42488232-vmss000000   Ready    agent    8m33s   v1.17.16   10.240.0.34    <none>        Ubuntu 18.04.5 LTS   5.4.0-1032-azure   containerd://1.3.9+azure
k8s-agentpool1-42488232-vmss000001   Ready    agent    8m33s   v1.17.16   10.240.0.65    <none>        Ubuntu 18.04.5 LTS   5.4.0-1032-azure   containerd://1.3.9+azure
k8s-master-42488232-0                Ready    master   8m33s   v1.17.16   10.255.255.5   <none>        Ubuntu 18.04.5 LTS   5.4.0-1032-azure   containerd://1.3.9+azure
======================================================================================

[andyzhangx]

Same error.

helm.go:81: [debug] unable to recognize "": no matches for kind "CSIDriver" in version "storage.k8s.io/v1"

Kubernetes version is still 1.17.16. We need version 1.18 or above

print out all nodes status ...
NAME                                 STATUS   ROLES    AGE     VERSION    INTERNAL-IP    EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION     CONTAINER-RUNTIME
k8s-agentpool1-42488232-vmss000000   Ready    agent    8m33s   v1.17.16   10.240.0.34    <none>        Ubuntu 18.04.5 LTS   5.4.0-1032-azure   containerd://1.3.9+azure
k8s-agentpool1-42488232-vmss000001   Ready    agent    8m33s   v1.17.16   10.240.0.65    <none>        Ubuntu 18.04.5 LTS   5.4.0-1032-azure   containerd://1.3.9+azure
k8s-master-42488232-0                Ready    master   8m33s   v1.17.16   10.255.255.5   <none>        Ubuntu 18.04.5 LTS   5.4.0-1032-azure   containerd://1.3.9+azure
======================================================================================

I just tried to test running integration test...

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

@dr0pdb: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-csi-driver-smb-integration	eca3346	link	/test pull-csi-driver-smb-integration
pull-csi-driver-smb-e2e	eca3346	link	/test pull-csi-driver-smb-e2e
pull-csi-driver-smb-external-e2e	eca3346	link	/test pull-csi-driver-smb-external-e2e
pull-csi-driver-smb-e2e-gce	eca3346	link	/test pull-csi-driver-smb-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.