-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase memory limits of livenessprobe
and csi-node-driver-registrar
Windows containers.
#524
Increase memory limits of livenessprobe
and csi-node-driver-registrar
Windows containers.
#524
Conversation
Hi @luborpetr. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
livenessprobe
and csi-node-driver-registrar
Windows containers.
Pull Request Test Coverage Report for Build 2796229353
💛 - Coveralls |
@@ -122,13 +122,13 @@ windows: | |||
resources: | |||
livenessProbe: | |||
limits: | |||
memory: 100Mi | |||
memory: 128Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's set as 150Mi
, provide more buffer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can change that to 150Mi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set @andyzhangx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, luborpetr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is addressing random out of memory error generated by
livenessprobe
andcsi-node-driver-registrar
containers on Windows containerd hosts.Which issue(s) this PR fixes:
I found on Windows containerd hosts that it's not rare to see OOM failure of
livenessprobe
andcsi-node-driver-registrar
containers at the pod startup.My cluster configuration:
Looks like the issue can be fixed by simply increasing current memory limit from 100Mi to 128Mi
The issue has not been reproduced on Windows dockerd hosts (with docker 19.3.8).
Example of the error:
Release note: