Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase memory limits of livenessprobe and csi-node-driver-registrar Windows containers. #524

Merged
merged 6 commits into from
Aug 5, 2022

Conversation

luborpetr
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR is addressing random out of memory error generated by livenessprobe and csi-node-driver-registrar containers on Windows containerd hosts.

Which issue(s) this PR fixes:

I found on Windows containerd hosts that it's not rare to see OOM failure of livenessprobe and csi-node-driver-registrar containers at the pod startup.

My cluster configuration:

  • GKE version v1.21.14-gke.700
  • Containerd 1.6.2-gke.2
  • Windows Windows Server 2019 Datacenter 10.0.17763.3046

Looks like the issue can be fixed by simply increasing current memory limit from 100Mi to 128Mi

The issue has not been reproduced on Windows dockerd hosts (with docker 19.3.8).

Example of the error:

2022-08-02 17:06:12.799 CEST /workspace/vendor/google.golang.org/grpc/server.go:827 +0x434
2022-08-02 17:06:12.799 CEST runtime.(*mheap).alloc.func1()
2022-08-02 17:06:12.799 CEST internal/poll.runtime_pollWait(0x2b0b20550b0, 0x72)
2022-08-02 17:06:12.799 CEST /workspace/vendor/google.golang.org/grpc/server.go:828 +0x65 fp=0xc000429fe0 sp=0xc000429f90 pc=0xd797e5
2022-08-02 17:06:12.799 CEST goroutine 44 [running]:
2022-08-02 17:06:12.799 CEST /go/pkg/csiprow.XXXXmbIOCb/go-1.17.3/src/internal/poll/fd_windows.go:175 +0xe5
2022-08-02 17:06:12.799 CEST runtime.(*mcache).refill(0x2b08cc70eb8, 0x87)
2022-08-02 17:06:12.799 CEST /workspace/vendor/google.golang.org/grpc/server.go:864 +0x3ad fp=0xc000429f90 sp=0xc000429ed0 pc=0xd79d6d
2022-08-02 17:06:12.796 CEST fatal error: out of memory
2022-08-02 17:06:12.796 CEST runtime: VirtualAlloc of 32768 bytes failed with errno=1455
2022-08-02 17:06:11.240 CEST Skipping HTTP server because endpoint is set to: ""
2022-08-02 17:06:11.240 CEST Registration Server started at: /registration/smb.csi.k8s.io-reg.sock
2022-08-02 17:06:11.239 CEST Starting Registration Server at: /registration/smb.csi.k8s.io-reg.sock
2022-08-02 17:06:11.239 CEST CSI driver name: "smb.csi.k8s.io"
2022-08-02 17:06:11.233 CEST Calling CSI driver to discover driver name
2022-08-02 17:06:10.221 CEST Attempting to open a gRPC connection with: "unix://C:\\\\csi\\\\csi.sock"
2022-08-02 17:06:10.221 CEST Running node-driver-registrar in mode=registration
2022-08-02 17:06:10.220 CEST Version: v2.5.1

Release note:

Increase memory limits of `livenessprobe` and `csi-node-driver-registrar` Windows containers.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @luborpetr. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 3, 2022
@luborpetr luborpetr changed the title Hotfix/mem limits Increase memory limits of livenessprobe and csi-node-driver-registrar Windows containers. Aug 3, 2022
@coveralls
Copy link

coveralls commented Aug 3, 2022

Pull Request Test Coverage Report for Build 2796229353

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.131%

Totals Coverage Status
Change from base Build 2782859348: 0.0%
Covered Lines: 813
Relevant Lines: 955

💛 - Coveralls

@@ -122,13 +122,13 @@ windows:
resources:
livenessProbe:
limits:
memory: 100Mi
memory: 128Mi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's set as 150Mi, provide more buffer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can change that to 150Mi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set @andyzhangx

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2022
@andyzhangx
Copy link
Member

/retest

1 similar comment
@andyzhangx
Copy link
Member

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, luborpetr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit f68287e into kubernetes-csi:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants