Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add readOnlyRootFilesystem if possible #589

Merged
merged 1 commit into from
Mar 21, 2023
Merged

feat: add readOnlyRootFilesystem if possible #589

merged 1 commit into from
Mar 21, 2023

Conversation

farodin91
Copy link
Contributor

@farodin91 farodin91 commented Mar 3, 2023 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

Add containerSecurityContext for containers

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @farodin91!

It looks like this is your first PR to kubernetes-csi/csi-driver-smb 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-smb has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @farodin91. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2023
@farodin91 farodin91 force-pushed the add-containerSecurityContext branch from 7c1b47b to d1be187 Compare March 3, 2023 10:44
@farodin91 farodin91 changed the title Add containerSecurityContext for containers feat: add containerSecurityContext for containers Mar 3, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 3, 2023
@farodin91
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 3, 2023
@farodin91
Copy link
Contributor Author

/assign @msau42

@coveralls
Copy link

coveralls commented Mar 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4469106380

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.744%
Totals Coverage Status
Change from base Build 4359374046: 0.0%
Covered Lines: 812
Relevant Lines: 947
💛 - Coveralls

@msau42
Copy link

msau42 commented Mar 7, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2023
@andyzhangx
Copy link
Member

andyzhangx commented Mar 8, 2023 •
edited
Loading

this change does not work, similar issue: kubernetes-csi/csi-driver-nfs#422 (comment)

@farodin91 farodin91 force-pushed the add-containerSecurityContext branch from d1be187 to b9a96fb Compare March 20, 2023 11:33
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2023
@farodin91 farodin91 changed the title feat: add containerSecurityContext for containers feat: readOnlyRootFilesystem Mar 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2023
@farodin91 farodin91 changed the title feat: readOnlyRootFilesystem feat: add readOnlyRootFilesystem if possible Mar 20, 2023
@farodin91 farodin91 force-pushed the add-containerSecurityContext branch from b9a96fb to 48de720 Compare March 20, 2023 11:35
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2023
@farodin91
Copy link
Contributor Author

@msau42 updated

@farodin91 farodin91 force-pushed the add-containerSecurityContext branch from 48de720 to a288f10 Compare March 20, 2023 12:26
@farodin91
Copy link
Contributor Author

@msau42 i re added privileged to the controller

andyzhangx
andyzhangx reviewed Mar 20, 2023
View reviewed changes
charts/latest/csi-driver-smb/values.yaml Outdated
@@ -138,6 +138,10 @@ windows:
requests:
cpu: 10m
memory: 40Mi
containerSecurityContext:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is different from kubernetes-csi/csi-driver-nfs#422

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@andyzhangx
Copy link
Member

/retest

@farodin91
feat: add readOnlyRootFilesystem if possible
d48f15e 
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
@farodin91 farodin91 force-pushed the add-containerSecurityContext branch from a288f10 to d48f15e Compare March 20, 2023 14:06
andyzhangx
andyzhangx approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, farodin91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5b1fa5e into kubernetes-csi:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@farodin91 @k8s-ci-robot @coveralls @msau42 @andyzhangx