Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect kubelet path setting on v1.14 chart config #741

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: incorrect kubelet path setting on v1.14 chart config #741

merged 1 commit into from
Jan 25, 2024

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jan 25, 2024 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: incorrect kubelet path setting on v1.14 chart config

Which issue(s) this PR fixes:

Fixes #732

Requirements:

Special notes for your reviewer:

Release note:

fix: incorrect kubelet path setting on v1.14 chart config

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2024
@andyzhangx andyzhangx mentioned this pull request Jan 25, 2024
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7655479658

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.628%
Totals Coverage Status
Change from base Build 7651148530: 0.0%
Covered Lines: 942
Relevant Lines: 1183
💛 - Coveralls

@andyzhangx andyzhangx merged commit 6c12ee7 into kubernetes-csi:master Jan 25, 2024
16 of 21 checks passed
@andyzhangx andyzhangx mentioned this pull request Feb 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erro mount SMB shared with customized kubelet path
3 participants
@andyzhangx @k8s-ci-robot @coveralls